Diary IPM feedback

I had my IPM today which I had the following feedbacks.

  • No static class

    The Minimax class was a static class as I felt at the time that a client wouldn’t need to instantiate an instance of minimax, this lead to static variables within the class. Leading to a dangerous road where I’m no longer using the advantages of OOP, advantages such as polymorphism.

  • Delete old branches
    Over time I’ve created a lot of feature branches while developing my Tic tac toe, Chris rightly suggested that I streamline it to only 2 branches. My current feature branch and the master branch. This makes it easier for to review pull requests as there’s only one branch to inspect.

  • Add travis CI
    I’ve had some experience with Hudson and Jenkins continuous integration in a previous employment. I found that straightforward to setup as it can ran Apache Maven based projects as well as support for batch scripts( which i set it up for custom behaviour), which I hope Travis CI has support for. Looking forward to it as I really like the idea behind CI.c wjkc

Advertisements

Leave a Reply

Please log in using one of these methods to post your comment:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out / Change )

Twitter picture

You are commenting using your Twitter account. Log Out / Change )

Facebook photo

You are commenting using your Facebook account. Log Out / Change )

Google+ photo

You are commenting using your Google+ account. Log Out / Change )

Connecting to %s